Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(contentful): createUrl now enforces https protocol #33236

Merged
merged 3 commits into from
Sep 20, 2021
Merged

fix(contentful): createUrl now enforces https protocol #33236

merged 3 commits into from
Sep 20, 2021

Conversation

axe312ger
Copy link
Collaborator

As we always have a https variant of an image available in Contentful, we can safely enforce https for all images.

based on @wardpeet's suggestion @ #30391 (comment)

(This will remove noise in the #30391 PR)

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Sep 17, 2021
@axe312ger axe312ger added topic: source-contentful Related to Gatsby's integration with Contentful and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Sep 17, 2021
@axe312ger axe312ger self-assigned this Sep 17, 2021
@wardpeet wardpeet added the bot: merge on green Gatsbot will merge these PRs automatically when all tests passes label Sep 20, 2021
wardpeet
wardpeet previously approved these changes Sep 20, 2021
View reviewed changes
@wardpeet wardpeet force-pushed the fix/contentful-enforce-https-for-images branch from cd7c5a9 to b150309 Compare September 20, 2021 12:37
@wardpeet wardpeet force-pushed the fix/contentful-enforce-https-for-images branch from b150309 to 9f173c9 Compare September 20, 2021 12:39
wardpeet
wardpeet approved these changes Sep 20, 2021
View reviewed changes
Copy link
Contributor

@wardpeet wardpeet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wardpeet wardpeet merged commit e166cfc into master Sep 20, 2021
@wardpeet wardpeet deleted the fix/contentful-enforce-https-for-images branch September 20, 2021 14:51
@axe312ger axe312ger mentioned this pull request Sep 25, 2021
Merged
5 tasks
@gatsbybot gatsbybot mentioned this pull request Oct 5, 2021
Closed
vladar pushed a commit that referenced this pull request Oct 5, 2021
@axe312ger @vladar
fix(contentful): createUrl now enforces https protocol (#33236)
aaa5609 
Co-authored-by: Ward Peeters <ward@coding-tech.com>
(cherry picked from commit e166cfc)
wardpeet added a commit to herecydev/gatsby that referenced this pull request Oct 29, 2021
@axe312ger @wardpeet
fix(contentful): createUrl now enforces https protocol (gatsbyjs#33236)
38650cc 
Co-authored-by: Ward Peeters <ward@coding-tech.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wardpeet wardpeet wardpeet approved these changes

Assignees

@axe312ger axe312ger

Labels
bot: merge on green Gatsbot will merge these PRs automatically when all tests passes topic: source-contentful Related to Gatsby's integration with Contentful
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@axe312ger @wardpeet